Skip to content

fix: point eslint package entries to preset#1499

Merged
sullivanpj merged 2 commits into
storm-software:mainfrom
Pugsin:codex/fix-eslint-package-entrypoints
Jul 6, 2026
Merged

fix: point eslint package entries to preset#1499
sullivanpj merged 2 commits into
storm-software:mainfrom
Pugsin:codex/fix-eslint-package-entrypoints

Conversation

@Pugsin

@Pugsin Pugsin commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • point @storm-software/eslint package-level main and types at the published preset entry files
  • leave the existing exports map unchanged

Why

The published package root export already resolves to dist/preset.js / dist/preset.d.ts, but the package-level main and types fields point to dist/index.js / dist/index.d.ts. Those dist/index.* files are not present in the npm tarball, so tooling that reads the legacy package fields can resolve to missing files.

Validation

  • npm view @storm-software/eslint@0.170.90 main types exports --json
  • npm pack @storm-software/eslint@0.170.90 --dry-run --json confirms dist/preset.js and dist/preset.d.ts are published, while dist/index.js is not
  • node -e "const p=require('./packages/eslint/package.json'); if(p.main!=='./dist/preset.js'||p.types!=='./dist/preset.d.ts') process.exit(1)"
  • git diff --check

Note: I could not run full pnpm workspace gates here because pnpm is not installed in this environment. This is a package metadata-only fix.

@Pugsin
Pugsin requested a review from a team June 21, 2026 22:22
@Pugsin
Pugsin requested review from a team and sullivanpj as code owners June 21, 2026 22:22

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I'm 🤖 Stormie-Bot (Storm Increased Efficiency Robot)! The Storm team sincerely appreciates your effort/interest in contributing to this project. A Storm developer will review this change and get back to you ASAP. Please feel free to reach out to the Storm team (contact@stormsoftware.com) if you have any questions/comments.

@sullivanpj
sullivanpj merged commit 63c122e into storm-software:main Jul 6, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants